Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide imap auth interface for plugins #9418

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Provide imap auth interface for plugins #9418

wants to merge 3 commits into from

Commits on Jul 15, 2024

  1. Add flag to avoid setting/creating user on login 

    Fixes roundcube#9377 . Allows rcmail::login() to be reused in plugins providing
an API. The login function provides some useful logic for connecting to
IMAP sources like checking credentials for validity or converting
usernames in some cases.

Before this change the login function always also created non-existing
users or set some sesison vars, which what API plugins would like to
avoid.
    @jaudriga
    jaudriga committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8b291d7 View commit details
    Browse the repository at this point in the history

  2. Provide function in rcube to connect to IMAP 

    This is useful for plugins like FreeBusy [1] that previously
connected to IMAP via plain rcube_imap::connect().

[1] https://git.kolab.org/source/freebusy/browse/master/lib/Kolab/FreeBusy/SourceIMAP.php
    @jaudriga
    jaudriga committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9b65ce1 View commit details
    Browse the repository at this point in the history

  3. Address feedback from alecpl 

    * rename `imap_connect` to `storage_connect`
* rename `rcmail::storage_connect` to `storage_connect_from_session`
* let `storage_connect` return rcube_user
* let `storage_connect` include more code from `login()`
    @jaudriga
    jaudriga committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    110a6a0 View commit details
    Browse the repository at this point in the history