-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render each mime-part into an individual iframe #9519
base: master
Are you sure you want to change the base?
Conversation
ba35bc4
to
2804d9d
Compare
2804d9d
to
d6a17b3
Compare
d6a17b3
to
b3ff9c8
Compare
3a8353c
to
edf0cc8
Compare
@alecpl I didn't find any problems, but still want to check some more plugins. Also one test is missing. But I think the general approach won't change anymore, so a review would already make sense. |
@alecpl Do you think we should keep "larry" working for future releases? I'm not sure yet how much work it would be to make larry fit for this change, but before I even try I want to be sure that you consider it necessary. (I would deprecate it and keep it maintained for v1.6.x, but not later versions.) |
7e519b5
to
0f5f90d
Compare
I'm finished with cleaning the commit history now. |
This allows for a little cleaner code
This probably wasn't implemented previously because HTML-parts usually didn't run through get.php.
That way it's testable.
Meta refresh would require unsafe-inline in a CSP, which we want to avoid.
0f5f90d
to
3d8b8d3
Compare
(Rebased to latest of "master".) |
@alecpl Could you give me your opinion on this? Please also review the code. |
Implementing #9465
TODO: