Default to C.UTF-8, allow fallback to C #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, the C.UTF-8 availability detection seems ugly and clumsy, and I have no idea whether it works on non-glibc (tested on Fedora 38). Better ideas welcome. |
|
Having slept on it, I wonder if we should just make C.UTF-8 the default because most (relevant) modern OS'es already have it, and just provide a cmake override for those that don't... |
Mostly everything around us is UTF-8 these days, we need to get on with the times. Especially now that glibc >= 2.35 finally supports it too. Default to C.UTF-8 but allow disabling it via cmake option to fallback to the traditional C locale instead. Fixes: rpm-software-management#2587
|
After sleeping some more on it, changed it to simply default to C.UTF-8 with an explicit override for trad. C for those who need it. It's much simpler and more reliable that way. |
pmatilai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly everything around us is UTF-8 these days, we need to get on with the times. Especially now that glibc >= 2.35 finally supports it too. Attempt to detect C.UTF-8 availability in cmake and prefer when available, fall back to C when not.
Fixes: #2587