Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to allow all methods #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

contrun
Copy link

@contrun contrun commented Sep 26, 2021

This PR add a wildcard option * to allow all methods specified in Access-Control-Request-Method. I was trying to access webdav files from organice. My preflight request is like this curl -vvvvvv -H 'Access-Control-Request-Method: PROPFIND' -H 'Access-Control-Request-Headers: authorization,depth' -H 'Origin: https://organice.200ok.ch' -X OPTIONS http://example.com. There is a few custom http verbs for webdav. I think it makes sense to allow all the http methods, so I added an option to allow all methods, just like the option to allow all http headers.

@jub0bs
Copy link
Contributor

jub0bs commented Apr 28, 2024

@contrun Good idea; that would indeed be useful. Do you have any interest (even after so long) in resolving your branch's conflicts? Otherwise, I'm considering submitting my own PR.

@contrun
Copy link
Author

contrun commented May 1, 2024

@jub0bs I rebased my commit.

@jub0bs
Copy link
Contributor

jub0bs commented May 1, 2024

@contrun Looks good, but could you add a couple of test cases to cover this new functionality? I think the maintainer would likely merge the PR then.

@jub0bs
Copy link
Contributor

jub0bs commented Jul 8, 2024

@contrun Are you still interested in this contribution? If so, will you have time to add a few test cases for it?

@contrun
Copy link
Author

contrun commented Jul 8, 2024

@jub0bs Sorry I don't have time to do this. Please submit your own PR. Thanks. Feel free to close this one.

@jub0bs
Copy link
Contributor

jub0bs commented Jul 8, 2024

@contrun No worries; I just wanted to know. Someone else can take it from here. Thanks for contributing the idea and this PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants