fixes netty-tcnative-boringssl-static dependency resolution #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seregamorph
commented
Apr 16, 2021
| @@ -23,7 +23,7 @@ plugins { | |||
| } | |||
|
|
|||
| def os_suffix = "" | |||
| if (osdetector.classifier in ["linux-x86_64"] || ["osx-x86_64"] || ["windows-x86_64"]) { | |||
There was a problem hiding this comment.
this condition was always true (constant)
rstoyanchev
approved these changes
Apr 27, 2021
|
Hey. Still any concerns/objections about it? |
OlegDokuka
changed the title
|
@seregamorph thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix resolution of
netty-tcnative-boringssl-staticartifact classifier.Motivation:
On apple m1 mac, that is resolved as
osdetector.classifier="osx-aarch_64"in gradle IntelliJ fails to import the project with diagnostics:Modifications:
Root cause is wrong resolution of
os_suffixvariable. Fixed.Result:
Verified on architectures:
osx-aarch_64,linux-x86_64,osx-x86_64.Apple M1 machines now can import the project and execute tests via gradle CLI.