Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make :example and :context scopes primary. #1421

Merged
merged 6 commits into from
Mar 21, 2014
Merged

Make :example and :context scopes primary. #1421

merged 6 commits into from
Mar 21, 2014

Conversation

myronmarston
Copy link
Member

Fixes #1184.

@myronmarston
Copy link
Member Author

I also did some more code auditing on top of this...that's what the rest of the commits are for.

Very close to being done with auditing rspec-core.

/cc @JonRowe

@JonRowe
Copy link
Member

JonRowe commented Mar 21, 2014

So this LGTM but it's changing method visibility and thus failing the test suite?

@myronmarston
Copy link
Member Author

So this LGTM but it's changing method visibility and thus failing the test suite?

Woops, missed that somehow. I just pushed fixes; will merge when green.

myronmarston added a commit that referenced this pull request Mar 21, 2014
@myronmarston
Merge pull request #1421 from rspec/swap-hook-aliases
339e459 
Make `:example` and `:context` scopes primary.
@myronmarston myronmarston merged commit 339e459 into master Mar 21, 2014
@myronmarston myronmarston deleted the swap-hook-aliases branch March 21, 2014 18:04
@yujinakayama yujinakayama mentioned this pull request Mar 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs to reference new hook scope names :context and :example
2 participants
@myronmarston @JonRowe