Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for present tense predicates #1286

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

pirj
Copy link
Member

@pirj pirj commented Jan 28, 2021

Fixes #935

@pirj pirj self-assigned this Jan 28, 2021
@pirj pirj added this to the 4.0 milestone Jan 28, 2021
@pirj pirj added the rspec 4 label Jan 28, 2021
@pirj pirj mentioned this pull request Jan 28, 2021
53 tasks
@pirj

This comment has been minimized.

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this is good, needs the PR number and I've suggested a tweak to the specs but I don't mind what you do.

spec/rspec/matchers/built_in/be_spec.rb Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@pirj pirj force-pushed the remove-support-for-present-tense-dynamic-predicate branch from 771d8a3 to b61855c Compare January 31, 2021 18:57
@pirj pirj merged commit 4f7c37d into 4-0-dev Jan 31, 2021
@pirj pirj deleted the remove-support-for-present-tense-dynamic-predicate branch January 31, 2021 19:13
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…rspec/remove-support-for-present-tense-dynamic-predicate

Remove support for present tense predicates

---
This commit was imported from rspec/rspec-expectations@4f7c37d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants