Remove a couple of remaining deprecations #1288
Conversation
| # instance variable when a deprecated implicit block expectation | ||
| # syntax is used. This may be removed once `fail` is used, and the | ||
| # matcher never issues this warning. | ||
| @actual_after = UNDEFINED |
There was a problem hiding this comment.
Yes, previously we weren't initializing it https://github.com/rspec/rspec-expectations/blame/bd10f0cf3970932781efcd09b5e427877d16a6c2/lib/rspec/matchers/built_in/change.rb#L353
There was a problem hiding this comment.
No I mean the removal in this PR
There was a problem hiding this comment.
Oh. Yes. I've overlooked to remove this in #1285 after resolving conflicts with #1139.
I think this PR is the last change in Expectations to get it ready for the 4.0 release (apart from adding deprecation warnings to main and rebasing 4-0-dev on top of it).
Sanity check, however, shows that nothing fails on https://github.com/rspec/rspec-expectations/tree/fe0c4b7f (#1139) even with the removed @actual_after = UNDEFINED. Can't recall the exact reason I've added it in the first place.
There was a problem hiding this comment.
I'll extract this removal into a separate PR.
pirj
force-pushed
the
remove-deprecations-2
branch
from
65e3d3c
to
1270e00
Compare
…rspec/remove-deprecations-2 Remove a couple of remaining deprecations --- This commit was imported from rspec/rspec-expectations@dde2edc.
No description provided.