Fix output.to_stdout_from_any_process when $stdout has been reassigned #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running under rspec bisect runner, $stdout & $stderr are reassigned
to a StringIO, which would introduce spec errors.
("can't convert Tempfile into StringIO", when trying to reopen the
stream in CaptureStreamToTempfile)
Since CaptureStreamToTempfile reopens the stream rather than reassigning
it, I _think_ it makes sense to use STDOUT rather than whatever the
current value of $stdout is.
|
I don't have any objections to this approach apart from the fact it breaks our build due to having already redeclared std out, I'm not sure how to fix this yet... |
Otherwise it doesn't work when $stderr has previously been reassigned, like in the rspec-core test suite
|
I've pushed a possible fix, where instead of reopening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(An alternate fix for rspec/rspec-core#3113)
When running under rspec bisect runner, $stdout & $stderr are reassigned to a StringIO, which would cause "can't convert Tempfile into StringIO" when trying to reopen the stream in CaptureStreamToTempfile
Since CaptureStreamToTempfile reopens the stream rather than reassigning it, I think it makes sense to use STDOUT rather than whatever the current value of $stdout is.
(Please feel free to sanity-check that assumption. I've gone round in circles a few too many times on this)