Add pickling support for Python tokenizers #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
commented
Jun 12, 2020
| use vtext::tokenize::*; | ||
|
|
||
| #[pyclass] | ||
| #[pyclass(module = "vtext.tokenize")] |
There was a problem hiding this comment.
Due to PyO3/pyo3#474 that should have been fixed, but I still see the same error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #25
This adds
__getstate__/__setstate__methods to make pickling work, following discussion in PyO3/pyo3#100 and adapting the https://gist.github.com/ethanhs/fd4123487974c91c7e5960acc9aa2a77 example.There is probably some way to add those methods via macros to avoid code repetition but I haven't figured it out yet.
Pickling support for
stemandvectorizemodules will be added in a follow up PR.This also removes the parameter attributes from python wrappers e.g.
RegexpTokenizer.patternas they were anyway not synced with the Rust parameter struct (hereRegexpTokenizer.inner.params.pattern), so changing them had no effect. If we want to make it work we could rather first make sureset_params/get_paramsmethods are working as expected, and then implement them via__getattr__/__setattr__.