Chrome Manifest Tweaks (fixes #406)

* remove suggested keys for 2 commands in all browsers except Firefox * only request optional "cookies" permission for Firefox * update keyboard shortcuts documentation to note per-browser defaults (or lack thereof)
rthaut · Jun 21, 2023 · dbac884 · dbac884
1 parent cb440e1
commit dbac884
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/app/manifest.json b/app/manifest.json
@@ -44,13 +44,13 @@
       "description": "__MSG_OpenPopoutCommandDescription__"
     },
     "open-popout-force-close-command": {
-      "suggested_key": {
+      "__firefox__suggested_key": {
         "default": "Alt+Shift+PageUp"
       },
       "description": "__MSG_OpenPopoutForceCloseCommandDescription__"
     },
     "open-popout-no-close-command": {
-      "suggested_key": {
+      "__firefox__suggested_key": {
         "default": "Alt+Shift+PageDown"
       },
       "description": "__MSG_OpenPopoutNoCloseCommandDescription__"
@@ -100,6 +100,9 @@
     "webRequestBlocking"
   ],
   "optional_permissions": [
+    "tabs"
+  ],
+  "__firefox__optional_permissions": [
     "cookies",
     "tabs"
   ],
@@ -111,4 +114,4 @@
       "strict_min_version": "62.0"
     }
   }
-}
+}
diff --git a/docs/pages/options.html b/docs/pages/options.html
@@ -289,23 +289,34 @@ <h4 class="hide">Keyboard Shortcuts</h4>
                                 <li>☑ AND if you are viewing a page on youtube.com</li>
                             </ul>
                         </td>
-                        <td><kbd>Ctrl</kbd> + <kbd>Up Arrow</kbd></td>
+                        <td>
+                            <strong>All Browsers:</strong><br>
+                            <kbd>Ctrl</kbd> + <kbd>Up Arrow</kbd>
+                        </td>
                     </tr>
                     <tr>
                         <td>
                             <span class="badge grey darken-1 white-text">New in v4.0</span>
                             <strong>Open popout player and close the current window/tab</strong><br>
                             <p>The current window/tab will be closed <span style="border-bottom: 1px solid">if you are viewing a page on youtube.com</span>, regardless of the "Close Original Window/Tab" setting.</p>
                         </td>
-                        <td><kbd>Shift</kbd> + <kbd>Alt</kbd> + <kbd>Page Up</kbd></td>
+                        <td>
+                            <strong>Firefox:</strong><br>
+                            <kbd>Shift</kbd> + <kbd>Alt</kbd> + <kbd>Page Up</kbd><br>
+                            <p><strong>Note:</strong> Other browsers do not have a default key binding upon installation, but you can manually set one.</p>
+                        </td>
                     </tr>
                     <tr>
                         <td>
                             <span class="badge grey darken-1 white-text">New in v4.0</span>
                             <strong>Open popout player without closing the current window/tab</strong><br>
                             <p>The current window/tab will not be closed, regardless of the "Close Original Window/Tab" setting.</p>
                         </td>
-                        <td><kbd>Shift</kbd> + <kbd>Alt</kbd> + <kbd>Page Down</kbd></td>
+                        <td>
+                            <strong>Firefox:</strong><br>
+                            <kbd>Shift</kbd> + <kbd>Alt</kbd> + <kbd>Page Down</kbd><br>
+                            <p><strong>Note:</strong> Other browsers do not have a default key binding upon installation, but you can manually set one.</p>
+                        </td>
                     </tr>
                 </tbody>
             </table>