Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runners in language module #746

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Runners in language module #746

merged 2 commits into from
Mar 8, 2019

Conversation

bquorning
Copy link
Collaborator

Extract a named Language constant from the duplicated {:to :not_to :to_not}/{:to :to_not :not_to} in our node matchers.

Language::Runners is extracted from #726.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from pirj and Darhazer March 8, 2019 08:09
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Will update my pull request once this is merged.

Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how those should be called.

@bquorning bquorning merged commit 0b253b8 into master Mar 8, 2019
@bquorning bquorning deleted the runners-in-language-module branch March 8, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants