Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rb_iseqw_to_iseq to get iseq pointer #1093

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Use rb_iseqw_to_iseq to get iseq pointer #1093

merged 2 commits into from
Mar 29, 2024

Conversation

peterzhu2118
Copy link
Member

Using DATA_PTR is internal implementation details so we should not use it.

It should fix this issue: ruby/ruby#10336 (comment)

Only `struct rb_iseq_struct`` and `rb_iseq_t`` are valid names, `struct rb_iseq`
is not a valid name.
Using DATA_PTR is internal implementation details so we should not use it.
@peterzhu2118 peterzhu2118 requested a review from ko1 March 27, 2024 15:35
Copy link

launchable-app bot commented Mar 27, 2024

Launchable Report

❌ Test session #2763453 failedos:ubuntu-latest test_task:test_protocoldetails on CI
🔔 no issues ✖️1 test failed ✔️63 tests passed

❌ Test session #2763454 failedos:ubuntu-latest test_task:test_protocoldetails on CI
🔔 no issues ✖️1 test failed ✔️63 tests passed

❌ Test session #2763485 failedos:ubuntu-latest test_task:test_protocoldetails on CI
🔔 no issues ✖️1 test failed ✔️63 tests passed

❌ Test session #2763490 failedos:ubuntu-latest test_task:test_protocoldetails on CI
🔔 no issues ✖️1 test failed ✔️63 tests passed

Passed test sessions

✅ Test session #2763443 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763444 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763445 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763446 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763447 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763448 passed os:ubuntu-latest test_task:test_testdetails on CI
✅ Test session #2763449 passed os:ubuntu-latest test_task:test_protocoldetails on CI
✅ Test session #2763450 passed os:ubuntu-latest test_task:test_protocoldetails on CI
✅ Test session #2763451 passed os:ubuntu-latest test_task:test_protocoldetails on CI
✅ Test session #2763452 passed os:ubuntu-latest test_task:test_protocoldetails on CI
✅ Test session #2763455 passed os:ubuntu-latest test_task:test_protocoldetails on CI
✅ Test session #2763460 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763461 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763462 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763463 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763464 passed os:macos-latest test_task:test_consoledetails on CI
✅ Test session #2763465 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763466 passed os:macos-latest test_task:test_consoledetails on CI
✅ Test session #2763467 passed os:macos-latest test_task:test_consoledetails on CI
✅ Test session #2763468 passed os:ubuntu-latest test_task:test_consoledetails on CI
✅ Test session #2763548 passed os:ubuntu-latest test_task:test_consoledetails on CI

Build: refs_pull_1093_merge_2d48ffe69ebebf712fe934309fc014e8b37d8959

@ko1 ko1 merged commit ffbdb30 into master Mar 29, 2024
26 of 28 checks passed
@ko1 ko1 deleted the pz-iseqw branch March 29, 2024 08:15
@ko1
Copy link
Collaborator

ko1 commented Mar 29, 2024

Thanks!

xjunior referenced this pull request in powerhome/audiences Apr 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [debug](https://github.com/ruby/debug) | `1.9.1` -> `1.9.2` |
[![age](https://developer.mend.io/api/mc/badges/age/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ruby/debug (debug)</summary>

### [`v1.9.2`](https://github.com/ruby/debug/releases/tag/v1.9.2)

[Compare
Source](https://github.com/ruby/debug/compare/v1.9.1...v1.9.2)

#### What's Changed

-   config
- Make irb_console toggleable with config update by
[@&#8203;st0012](https://github.com/st0012) in
[https://github.com/ruby/debug/pull/1057](https://github.com/ruby/debug/pull/1057)
-   internal
- Stop assuming Array#each is written in C by
[@&#8203;k0kubun](https://github.com/k0kubun) in
[https://github.com/ruby/debug/pull/1061](https://github.com/ruby/debug/pull/1061)
- Add `base64` gem to the dependencies by
[@&#8203;y-yagi](https://github.com/y-yagi) in
[https://github.com/ruby/debug/pull/1066](https://github.com/ruby/debug/pull/1066)
- Support Ruby 3.4's new error message format by
[@&#8203;hsbt](https://github.com/hsbt) in
[https://github.com/ruby/debug/pull/1080](https://github.com/ruby/debug/pull/1080)
- catch up ruby 3.4.0 error related changes by
[@&#8203;ko1](https://github.com/ko1) in
[https://github.com/ruby/debug/pull/1083](https://github.com/ruby/debug/pull/1083)
- Fix syntax warnings by
[@&#8203;casperisfine](https://github.com/casperisfine) in
[https://github.com/ruby/debug/pull/1072](https://github.com/ruby/debug/pull/1072)
- Drop base64 dependency by
[@&#8203;Earlopain](https://github.com/Earlopain) in
[https://github.com/ruby/debug/pull/1071](https://github.com/ruby/debug/pull/1071)
- Fix ENOENT error when readline is not loaded by
[@&#8203;lazyatom](https://github.com/lazyatom) in
[https://github.com/ruby/debug/pull/1073](https://github.com/ruby/debug/pull/1073)
- Remove and Restore irb configuration like irbrc while irb console
tests by [@&#8203;hsbt](https://github.com/hsbt) in
[https://github.com/ruby/debug/pull/1067](https://github.com/ruby/debug/pull/1067)
- Use rb_iseqw_to_iseq to get iseq pointer by
[@&#8203;peterzhu2118](https://github.com/peterzhu2118) in
[https://github.com/ruby/debug/pull/1093](https://github.com/ruby/debug/pull/1093)
-   tests
- Add Ruby 3.3 to CI matrix by
[@&#8203;st0012](https://github.com/st0012) in
[https://github.com/ruby/debug/pull/1058](https://github.com/ruby/debug/pull/1058)
- Use ruby/actions workflow for ruby versions by
[@&#8203;m-nakamura145](https://github.com/m-nakamura145) in
[https://github.com/ruby/debug/pull/1065](https://github.com/ruby/debug/pull/1065)
- Separate setup and execution steps in CI by
[@&#8203;ono-max](https://github.com/ono-max) in
[https://github.com/ruby/debug/pull/1088](https://github.com/ruby/debug/pull/1088)
- Fix flakey test "test_reponse_returns_correct_threads_info" by
[@&#8203;ono-max](https://github.com/ono-max) in
[https://github.com/ruby/debug/pull/1089](https://github.com/ruby/debug/pull/1089)
- Add Launchable in CI by
[@&#8203;ono-max](https://github.com/ono-max) in
[https://github.com/ruby/debug/pull/1090](https://github.com/ruby/debug/pull/1090)
-   doc
- Correct the irb command's description by
[@&#8203;st0012](https://github.com/st0012) in
[https://github.com/ruby/debug/pull/1056](https://github.com/ruby/debug/pull/1056)
- Fix prelude doc example to use curly braces by
[@&#8203;adam12](https://github.com/adam12) in
[https://github.com/ruby/debug/pull/1052](https://github.com/ruby/debug/pull/1052)
- Mention IRB console in readme by
[@&#8203;st0012](https://github.com/st0012) in
[https://github.com/ruby/debug/pull/1092](https://github.com/ruby/debug/pull/1092)

#### New Contributors

- [@&#8203;Earlopain](https://github.com/Earlopain) made their first
contribution in
[https://github.com/ruby/debug/pull/1071](https://github.com/ruby/debug/pull/1071)
- [@&#8203;lazyatom](https://github.com/lazyatom) made their first
contribution in
[https://github.com/ruby/debug/pull/1073](https://github.com/ruby/debug/pull/1073)
- [@&#8203;m-nakamura145](https://github.com/m-nakamura145) made their
first contribution in
[https://github.com/ruby/debug/pull/1065](https://github.com/ruby/debug/pull/1065)

**Full Changelog**:
ruby/debug@v1.9.1...v1.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/powerhome/audiences).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants