Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

support for windows with scons #40

Closed
wants to merge 1 commit into from

Conversation

stereobooster
Copy link
Contributor

solution for #29

@cowboyd
Copy link
Collaborator

cowboyd commented Jun 29, 2012

This is incredible work that you're doing.

Were you able to build v8 as a static library? The reason I say this is that it will allow us to distribute a binary version of therubyracer that does not depend on the shared library because it will all be linked directly into the rubyracer binary.

@stereobooster
Copy link
Contributor Author

Were you able to build v8 as a static library

It seems to me, that answer is no.

I downloaded therubyracer-0.11.0beta1-x86-mingw32.gem on the other PC. Then gem install it. When I'm doing require 'v8'. It gives an error - no v8.dll

@cowboyd
Copy link
Collaborator

cowboyd commented Jun 29, 2012

This is because you built v8 with library=shared so you built therubyracer against a .dll. When it tries to load on your other PC, it cannot find the v8.dll. However, if you link therubyracer against v8.a, then therubyracer will include v8 in its entirety statically linked.

can you build v8 with library=static instead of library=shared?

@stereobooster
Copy link
Contributor Author

I can build v8 with library=static. But building therubyracer give me error

@stereobooster
Copy link
Contributor Author

Problem with timeGetTime go away if link to libwinmm:

have_library('winmm') if mingw?

But tests freeze after third one

Run options: exclude {:memory=>true, :threads=>true}
*..

Problem example is can be initialized with a length. If I comment it out, there are other cases where it hangs.

Tried add pthreads from here. Didn't help

@stereobooster
Copy link
Contributor Author

Were you able to build v8 as a static library

Yes. But therubyracer tests freeze. What about packing v8.dll in therubyracer windows binary gem? It simplest solution for now.

I compiled list of available options

@ignisf
Copy link
Collaborator

ignisf commented Jan 11, 2013

It seems that scons has been deprecated in recent versions of v8 and GYP is to be used when building on Windows, too. This also affects #41 and #37 :/

@stereobooster stereobooster mentioned this pull request Jan 24, 2013
@ignisf
Copy link
Collaborator

ignisf commented Dec 5, 2013

See #111

@ignisf ignisf closed this Dec 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants