sqllogictest: Fix the Nightly SLT test

make a dedicated workflow in test/sqllogictest/mzcompose.yml the way one existed for the sql-fast test
ruchirK · Jun 21, 2021 · df7d083 · df7d083
1 parent b540cbe
commit df7d083
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/ci/slt/pipeline.yml b/ci/slt/pipeline.yml
@@ -8,7 +8,8 @@
 # by the Apache License, Version 2.0.
 
 steps:
-  - command: ci/slt/slt.sh
+  - id: sqllogictest
+    label: ":bulb: SQL logic tests"
     timeout_in_minutes: 300
     artifact_paths: target/slt-summary.json
     plugins:

diff --git a/ci/slt/slt.sh b/ci/slt/slt.sh
@@ -13,18 +13,6 @@
 
 set -euo pipefail
 
-. misc/shlib/shlib.bash
-
-if [[ ! "${BUILDKITE-}" ]]; then
-    sqllogictest() {
-        cargo run --release --bin sqllogictest -- "$@"
-    }
-fi
-
-if [[ "${BUILDKITE-}" ]]; then
-    await_postgres -h postgres -p 5432
-fi
-
 export RUST_BACKTRACE=full
 
 mkdir -p target

diff --git a/test/sqllogictest/mzcompose.yml b/test/sqllogictest/mzcompose.yml
@@ -18,6 +18,17 @@ mzworkflows:
         dbname: postgres
       - step: run
         service: sqllogictest-svc
+        entrypoint: ci/test/slt-fast.sh
+
+  sqllogictest:
+    steps:
+      - step: start-services
+        services: [postgres]
+      - step: wait-for-postgres
+        dbname: postgres
+      - step: run
+        service: sqllogictest-svc
+        entrypoint: ci/slt/slt.sh
 
 services:
   sqllogictest-svc:
@@ -31,8 +42,6 @@ services:
     - PGHOST=postgres
     - PGPASSWORD=postgres
     depends_on: [postgres]
-    entrypoint:
-    - ci/test/slt-fast.sh
   postgres:
     image: postgres:11.4
     ports: