Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server rejection #199

Closed
wants to merge 9 commits into from
Closed

Server rejection #199

wants to merge 9 commits into from

Conversation

russelltg
Copy link
Owner

Fixes #196

@russelltg russelltg marked this pull request as ready for review March 23, 2023 23:16
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (36f92e6) 77.54% compared to head (0eee1f6) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   77.54%   77.56%   +0.02%     
==========================================
  Files          85       85              
  Lines       14000    14005       +5     
==========================================
+ Hits        10856    10863       +7     
+ Misses       3144     3142       -2     
Files Coverage Δ
srt-tokio/src/socket/listen.rs 71.87% <62.50%> (+5.20%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aegroto
Copy link

aegroto commented Oct 14, 2023

Why are the tests failing on MacOS only? The logs are not available anymore.

@russelltg
Copy link
Owner Author

Rebased, we'll see :)

@russelltg
Copy link
Owner Author

Gah, can't repro that failure on my mac :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle server rejection properly
3 participants