Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print a policy #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
202 changes: 202 additions & 0 deletions src/policy/semantic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

//! Abstract Policies

use std::collections::HashSet;
use std::str::FromStr;
use std::{fmt, str};

Expand Down Expand Up @@ -57,6 +58,80 @@ pub enum Policy<Pk: MiniscriptKey> {
Threshold(usize, Vec<Policy<Pk>>),
}

/// Compute the Policy difference between two policies.
/// This is useful when trying to find out the conditions
/// under which the two policies are different.
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord)]
pub struct PolicyDiff<Pk: MiniscriptKey> {
/// The first policy
pub a: Vec<Policy<Pk>>,
/// The second policy
pub b: Vec<Policy<Pk>>,
}

impl<Pk: MiniscriptKey> PolicyDiff<Pk> {
/// Combine two policy differences.
// Policies should not generally contain repeated conditions,
// therefore we do not many attempt to deal with those.
pub fn combine(&mut self, second: Self) {
self.a.extend(second.a);
self.b.extend(second.b);
}

// create a new diff directly without removing
// same policies.
fn _new(a: Vec<Policy<Pk>>, b: Vec<Policy<Pk>>) -> Self {
Self { a, b }
}

/// Create a new PolicyDiff in the
pub fn new(a: Policy<Pk>, b: Policy<Pk>) -> Self {
pub fn new_helper<Pk: MiniscriptKey>(a: Policy<Pk>, b: Policy<Pk>) -> PolicyDiff<Pk> {
match (a, b) {
(ref x, ref y) if x == y => PolicyDiff::_new(vec![], vec![]),
(Policy::Threshold(k1, subs1), Policy::Threshold(k2, subs2)) => {
if k1 == k2 && subs1.len() == subs2.len() {
let mut ind_a = HashSet::new();
let mut ind_b = HashSet::new();
for i in 0..subs1.len() {
let sub_a = &subs1[i];
let b_pos = subs2.iter().position(|sub_b| sub_a == sub_b);
match b_pos {
Some(j) => {
ind_a.insert(i);
ind_b.insert(j);
}
None => {}
}
}
let diff_a: Vec<_> = subs1
.into_iter()
.enumerate()
.filter(|(i, _x)| !ind_a.contains(i))
.map(|(_i, p)| p)
.collect();
let diff_b = subs2
.into_iter()
.enumerate()
.filter(|(i, _x)| !ind_b.contains(i))
.map(|(_i, p)| p)
.collect::<Vec<_>>();
PolicyDiff::_new(diff_a, diff_b)
} else {
PolicyDiff::_new(
vec![Policy::Threshold(k1, subs1)],
vec![Policy::Threshold(k2, subs2)],
)
}
}
(x, y) => PolicyDiff::_new(vec![x], vec![y]),
}
}

new_helper(a.normalized(), b.normalized())
}
}

impl<Pk: MiniscriptKey> ForEachKey<Pk> for Policy<Pk> {
fn for_each_key<'a, F: FnMut(ForEach<'a, Pk>) -> bool>(&'a self, mut pred: F) -> bool
where
Expand All @@ -78,6 +153,42 @@ impl<Pk: MiniscriptKey> ForEachKey<Pk> for Policy<Pk> {
}

impl<Pk: MiniscriptKey> Policy<Pk> {
fn term_name(&self) -> String {
match *self {
Policy::Threshold(k, ref subs) => {
if k == subs.len() {
String::from(format!("and({},{})", k, subs.len()))
} else if k == 1 {
String::from(format!("or({},{})", k, subs.len()))
} else {
String::from(format!("thresh({},{})", k, subs.len()))
}
}
_ => self.to_string(),
}
}

fn _pprint_tree(&self, prefix: String, last: bool) {
let prefix_current = if last { "`-- " } else { "|-- " };

println!("{}{}{}", prefix, prefix_current, self.term_name());

let prefix_child = if last { " " } else { "| " };
let prefix = prefix + prefix_child;

if let Policy::Threshold(_k, ref subs) = *self {
let last_child = subs.len() - 1;

for (i, child) in subs.iter().enumerate() {
child._pprint_tree(prefix.to_string(), i == last_child);
}
}
}

/// Pretty Print a tree
pub fn pprint_tree(&self) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 4d23b79:

Can we make this pub(crate)? I think we can come up with a much better API here and I'd rather not expose this one.

self._pprint_tree("".to_string(), true);
}
/// Convert a policy using one kind of public key to another
/// type of public key
pub fn translate_pkh<Fpkh, Q, E>(&self, mut translatefpkh: Fpkh) -> Result<Policy<Q>, E>
Expand Down Expand Up @@ -105,6 +216,67 @@ impl<Pk: MiniscriptKey> Policy<Pk> {
}
}

fn _pprint_diff(&self, other: &Policy<Pk>, prefix: String, last: bool) {
match (self, other) {
(x, y) if x == y => x._pprint_tree(prefix, last),
(Policy::Threshold(k1, subs1), Policy::Threshold(k2, subs2))
if k1 == k2 && subs1.len() == subs2.len() =>
{
let prefix_current = if last { "`-- " } else { "|-- " };

println!("{}{}{}", prefix, prefix_current, self.term_name());

let prefix_child = if last { " " } else { "| " };
let prefix = prefix + prefix_child;

let last_child = subs1.len() - 1;

// Hashsets to maintain which children of subs are matched
// onto children from others
let mut ind_a = HashSet::new();
let mut ind_b = HashSet::new();
for i in 0..subs1.len() {
let sub_a = &subs1[i];
let b_pos = subs2.iter().position(|sub_b| sub_a == sub_b);
match b_pos {
Some(j) => {
ind_a.insert(i);
ind_b.insert(j);
}
None => {}
}
}
let mut j = 0;
for (i, sub_a) in subs1.iter().enumerate() {
// The position in subs2
if ind_a.contains(&i) {
sub_a._pprint_tree(prefix.to_string(), last);
} else {
while ind_b.contains(&j) {
j = j + 1;
}
sub_a._pprint_diff(&subs2[j], prefix.to_string(), i == last_child);
}
}
}
(x, y) => {
let red = "\x1b[0;31m";
let nc = "\x1b[0m";
let green = "\x1b[0;32m";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to come up with a different encoding scheme. It doesn't have to be pretty, we could provide a shellscript or something that converted it into a colorized version.

But using shell escape sequences means that we won't work on windows and are likely to confuse other command line tools.

print!("{}", green);
x._pprint_tree(prefix.clone(), last);
print!("{}{}", nc, red);
y._pprint_tree(prefix, last);
print!("{}", nc);
}
}
}

/// Pretty Print a tree
pub fn pprint_diff(&self, other: &Policy<Pk>) {
self._pprint_diff(other, "".to_string(), true);
}

/// This function computes whether the current policy entails the second one.
/// A |- B means every satisfaction of A is also a satisfaction of B.
/// This implementation will run slow for larger policies but should be sufficient for
Expand Down Expand Up @@ -633,6 +805,34 @@ mod tests {
);
}

#[test]
fn policy_diff() {
let pol1 = StringPolicy::from_str("or(pkh(A),pkh(C))").unwrap();
let pol2 = StringPolicy::from_str("or(pkh(B),pkh(C))").unwrap();
let diff = PolicyDiff::new(pol1.clone(), pol2.clone());
assert_eq!(
diff,
PolicyDiff::new(
StringPolicy::from_str("pkh(A)").unwrap(),
StringPolicy::from_str("pkh(B)").unwrap()
)
);
// Uncomment for pprint
// pol1.pprint_diff(&pol2);

let pol1 = StringPolicy::from_str("or(pkh(A),pkh(C))").unwrap();
// change the order
let pol2 = StringPolicy::from_str("or(pkh(C),and(pkh(B),older(9)))").unwrap();
let diff = PolicyDiff::new(pol1.clone(), pol2.clone());
assert_eq!(
diff,
PolicyDiff::new(
StringPolicy::from_str("pkh(A)").unwrap(),
StringPolicy::from_str("and(pkh(B),older(9))").unwrap()
)
);
}

#[test]
fn entailment_liquid_test() {
//liquid policy
Expand All @@ -641,6 +841,8 @@ mod tests {
// Very bad idea to add master key,pk but let's have it have 50M blocks
let master_key = StringPolicy::from_str("and(older(50000000),pkh(master))").unwrap();
let new_liquid_pol = Policy::Threshold(1, vec![liquid_pol.clone(), master_key]);
// Pretty print a policy
// liquid_pol.pprint_tree();

assert!(liquid_pol.clone().entails(new_liquid_pol.clone()).unwrap());
assert!(!new_liquid_pol.entails(liquid_pol.clone()).unwrap());
Expand Down