Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI + GHMQ + Improve readme #42

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 19, 2023

No description provided.

@eldruin eldruin requested a review from a team as a code owner July 19, 2023 06:37
@eldruin eldruin force-pushed the updates branch 5 times, most recently from a0ee7ab to 2756227 Compare July 19, 2023 07:07
write *core* I/O APIs that can then be adapted to operate in either blocking
or non-blocking manner. Furthermore those APIs are not tied to a particular
asynchronous model and can be adapted to work with the `futures` model or
with the `async` / `await` model.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note: Time has shown this is a bit of a lie, perhaps we could update it. For example you can't adapt nb to async/await because it has no wakers 🙃 . Also the terminology below about futures/await is super outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Could you make a wording update PR?

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Dirbaio Dirbaio merged commit 62c17d3 into rust-embedded:master Jul 20, 2023
11 checks passed
@eldruin eldruin deleted the updates branch July 20, 2023 09:14
Beanow added a commit to Beanow/nb that referenced this pull request Oct 26, 2023
Closes rust-embedded#43

The MSRV was bumped in rust-embedded#42 but missed the `package.rust-version` metadata.
eldruin pushed a commit that referenced this pull request Oct 27, 2023
Closes #43

The MSRV was bumped in #42 but missed the `package.rust-version` metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants