Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on the breaking PR #2

Closed
nrc opened this issue Jan 15, 2018 · 1 comment
Closed

Comment on the breaking PR #2

nrc opened this issue Jan 15, 2018 · 1 comment
Assignees
@kennytm

Comments

@nrc
Copy link

nrc commented Jan 15, 2018

So the author knows they broke something and can fix it if they want to.
@kennytm kennytm self-assigned this Jan 29, 2018
@kennytm kennytm mentioned this issue Feb 21, 2018
Closed
@kennytm kennytm mentioned this issue Feb 21, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Feb 22, 2018
@kennytm
Submit a comment to the PR in additional to pushing a commit.
e181050 
Fix rust-lang-nursery/rust-toolstate#2.
bors added a commit to rust-lang/rust that referenced this issue Feb 28, 2018
@bors
Auto merge of #48405 - kennytm:autotoolstate-follow-up, r=Mark-Simula…
ab1f09e 
…crum

Auto-toolstate management follow-up.

Tracking comment: #45861 (comment)

* Fixed rust-lang-nursery/rust-toolstate#1, a proper link to the PR will be included.
* Fixed rust-lang-nursery/rust-toolstate#2, a comment will be posted to the PR if the toolstate changed
* Toolstate regression will be rejected at the last week of the 6-week cycle (currently entirely date-based).
* Implemented https://internals.rust-lang.org/t/the-current-submodule-setup-is-not-tenable/6593, moved doc tests of Nomicon, Reference, Rust-by-Example and The Book to the "tools" job and thus allowed to fail like other external tools.
Manishearth added a commit to Manishearth/rust that referenced this issue Mar 1, 2018
@Manishearth
Rollup merge of rust-lang#48405 - kennytm:autotoolstate-follow-up, r=…
eadea4a 
…Mark-Simulacrum

Auto-toolstate management follow-up.

Tracking comment: rust-lang#45861 (comment)

* Fixed rust-lang-nursery/rust-toolstate#1, a proper link to the PR will be included.
* Fixed rust-lang-nursery/rust-toolstate#2, a comment will be posted to the PR if the toolstate changed
* Toolstate regression will be rejected at the last week of the 6-week cycle (currently entirely date-based).
* Implemented https://internals.rust-lang.org/t/the-current-submodule-setup-is-not-tenable/6593, moved doc tests of Nomicon, Reference, Rust-by-Example and The Book to the "tools" job and thus allowed to fail like other external tools.
@kennytm
Copy link
Contributor

kennytm commented Mar 8, 2018

(Fixed by rust-lang/rust#48405 already)

@kennytm kennytm closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennytm kennytm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennytm @nrc