Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.60.0 blog post #952

Merged
merged 11 commits into from
Apr 7, 2022
Merged

Add 1.60.0 blog post #952

merged 11 commits into from
Apr 7, 2022

Conversation

Mark-Simulacrum
Copy link
Member

This just inlines the release notes from rust-lang/rust#94817, but they aren't yet ready -- several more rounds of revision will be necessary there.

cc @rust-lang/release

@pnkfelix @wesleywiser This contains a section on incr comp status; I wrote up some language presuming we leave things enabled, but that can be iterated based on future decisions -- maybe at next week's planning meeting. Happy to see revisions of the text there.

@Mark-Simulacrum Mark-Simulacrum requested a review from a team as a code owner March 18, 2022 21:54
@Mark-Simulacrum Mark-Simulacrum changed the title Add blog post Add 1.60.0 blog post Mar 18, 2022
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM for putting this together!

posts/2022-04-07-Rust-1.60.0.md Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
Mark-Simulacrum and others added 3 commits March 21, 2022 07:37
Co-authored-by: Eric Huss <eric@huss.org>
Co-authored-by: Eric Huss <eric@huss.org>
Co-authored-by: Eric Huss <eric@huss.org>
@Mark-Simulacrum
Copy link
Member Author

@ehuss Thanks! I think the new text is indeed better. Are there plans to make the default syntax the "thing you want"? I wonder if we could make a slight reference to the next edition there, for example.

But probably isn't worth it.

@ehuss
Copy link
Contributor

ehuss commented Mar 21, 2022

There are no plans at this time to change the behavior. It could be considered, but is currently not on our radar.

Copy link

@richkadel richkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleywiser - Thanks for putting this together! Some suggestions.

posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
@pietroalbini
Copy link
Member

Looks good!

Mark-Simulacrum and others added 4 commits March 30, 2022 09:17
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
Co-authored-by: Ryan Levick <rylev@users.noreply.github.com>
@Mark-Simulacrum
Copy link
Member Author

Pushed updates per @richkadel's review -- thanks!

Co-authored-by: Tyler Mandry <tmandry@gmail.com>
@joshtriplett
Copy link
Member

I think we need to add the Duration changes to the blog post.

@joshtriplett
Copy link
Member

The Duration changes are now documented in the release notes; the corresponding section needs to get copied to the blog post.

@Mark-Simulacrum
Copy link
Member Author

I pushed a section, but I'm not particularly happy with it. Maybe we just cut down on what it says to something more barebones, not sure. It may make sense to promote some more of the discussion in rust-lang/rust#89926 to here.

@pietroalbini
Copy link
Member

pietroalbini commented Apr 6, 2022

I think the snippet you wrote works. @rust-lang/core can someone approve this so I can merge it tomorrow as part of the 1.60.0 release process?

Copy link
Member

@joshtriplett joshtriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some minor edits, no semantic changes.

posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
posts/2022-04-07-Rust-1.60.0.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@pietroalbini pietroalbini merged commit 1cfafa0 into rust-lang:master Apr 7, 2022
@pietroalbini pietroalbini deleted the 60blog branch April 7, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants