Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Add common profile validation. #10413

Merged
merged 2 commits into from
Feb 22, 2022
Merged

[beta] Add common profile validation. #10413

merged 2 commits into from
Feb 22, 2022

Commits on Feb 22, 2022

  1. Auto merge of rust-lang#10411 - ehuss:fix-rustflags-gate, r=alexcrichton 

    Add common profile validation.

This fixes an oversight where `rustflags` is not nightly-gated in a profile override (like `[profile.dev.package.foo]`).

The problem is that the validation was only being done for the top-level profile.
The solution here is to consolidate common profile validation that should be done for both the top level and the overrides. In the process I also fixed validation of `codegen-backend` which also is shared. This will hopefully help prevent other oversights in the future.
    @bors @ehuss
    bors authored and ehuss committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    ba955c5 View commit details
    Browse the repository at this point in the history

  2. Auto merge of rust-lang#10396 - jonhoo:clap-deprecations, r=epage 

    Avoid new deprecation warnings from clap 3.1.0

### What does this PR try to resolve?

This fixes a number of new deprecations in [clap 3.1.0](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#310---2022-02-16) that are currently causing CI to fail for all other PRs due to `-Dwarnings`.
    @bors @ehuss
    bors authored and ehuss committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0ebfe2e View commit details
    Browse the repository at this point in the history