test(install): use TCP connection instead of thread sleep #13099

weihanglo · 2023-12-02T05:14:10Z

What does this PR try to resolve?

The test install::uninstall_running_binary is flaky in CI job.

running `/Users/runner/work/cargo/cargo/target/debug/cargo install foo`
running `/Users/runner/work/cargo/cargo/target/debug/cargo uninstall foo`
thread '<unnamed>' panicked at tests/testsuite/install.rs:2568:66:
called `Result::unwrap()` on an `Err` value: process didn't exit successfully: `/Users/runner/work/cargo/cargo/target/tmp/cit/t1651/home/.cargo/bin/foo` (signal: 9, SIGKILL: kill)
thread 'install::uninstall_running_binary' panicked at tests/testsuite/install.rs:2588:18:
called `Result::unwrap()` on an `Err` value: Any { .. }

TCP connection is more robust than thread::sleep, ensuring

foo is running before the first cargo uninstall call
foo is stopped before the second cargo uninstall call

How should we test and review this PR?

Additional information

rustbot · 2023-12-02T05:14:16Z

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

weihanglo · 2023-12-02T05:18:25Z

This may block cargo submodule sync in rust-lang/rust.

This is more robust than `thread::sleep`, ensuring * foo is running before the first `cargo uninstall` call * foo is stopped before the second `cargo uninstall` call

epage · 2023-12-02T14:14:08Z

@bors r+

bors · 2023-12-02T14:14:11Z

📌 Commit 297b827 has been approved by epage

It is now in the queue for this repository.

bors · 2023-12-02T14:15:19Z

⌛ Testing commit 297b827 with merge 58fb231...

bors · 2023-12-02T14:43:46Z

☀️ Test successful - checks-actions
Approved by: epage
Pushing 58fb231 to master...

Update cargo 25 commits in 26333c732095d207aa05932ce863d850fb309386..58fb23140972092a12f7011d17a7db1d99e3eacf 2023-11-28 20:07:39 +0000 to 2023-12-02 14:15:16 +0000 - test(install): use TCP connection instead of thread sleep (rust-lang/cargo#13099) - test(mdman): Switch to snapbox (rust-lang/cargo#13098) - Include declared list of features in fingerprint for `-Zcheck-cfg` (rust-lang/cargo#13012) - chore(deps): update compatible (rust-lang/cargo#13083) - chore(ci): Always update gix packages together (rust-lang/cargo#13093) - chore(deps): update rust crate windows-sys to 0.52 (rust-lang/cargo#13089) - refactor(toml): Decouple logic from schema (rust-lang/cargo#13080) - Have cargo add --optional <dep> create a <dep> = "dep:<dep> feature (rust-lang/cargo#13071) - Add `--public` for `cargo add` (rust-lang/cargo#13046) - chore(deps): update rust crate toml_edit to 0.21.0 (rust-lang/cargo#13088) - chore(deps): update rust crate rusqlite to 0.30.0 (rust-lang/cargo#13087) - test(trim-paths): exercise with real world debugger (rust-lang/cargo#13091) - Fixed uninstall a running binary failed on Windows (rust-lang/cargo#13053) - chore(deps): update rust crate itertools to 0.12.0 (rust-lang/cargo#13086) - Add more options to registry test support. (rust-lang/cargo#13085) - Don't filter on workspace members when scraping doc examples (rust-lang/cargo#13077) - Remove the outdated comment (rust-lang/cargo#13076) - fix(resolver): Remove unused public-deps error handling (rust-lang/cargo#13036) - Fixes error count display is different when there's only one error left (rust-lang/cargo#12484) - fix: reorder `--remap-path-prefix` flags for `-Zbuild-std` (rust-lang/cargo#13065) - remove jobserver env var in some tests (rust-lang/cargo#13072) - doc: clarify different target has different set of `CARGO_CFG_*` values (rust-lang/cargo#13069) - docs: remove review capacity notice in PR template (rust-lang/cargo#13070) - chore(deps): update rust crate openssl to 0.10.60 [security] (rust-lang/cargo#13068) - fix(resolver): De-prioritize no-rust-version in MSRV resolver (rust-lang/cargo#13066) r? ghost

Update cargo 27 commits in 26333c732095d207aa05932ce863d850fb309386..623b788496b3e51dc2f9282373cf0f6971a229b5 2023-11-28 20:07:39 +0000 to 2023-12-02 18:10:03 +0000 - docs(book): make old title anchorable (rust-lang/cargo#13102) - Revert "chore(deps): update rust crate openssl to 0.10.60 [security]" (rust-lang/cargo#13101) - test(install): use TCP connection instead of thread sleep (rust-lang/cargo#13099) - test(mdman): Switch to snapbox (rust-lang/cargo#13098) - Include declared list of features in fingerprint for `-Zcheck-cfg` (rust-lang/cargo#13012) - chore(deps): update compatible (rust-lang/cargo#13083) - chore(ci): Always update gix packages together (rust-lang/cargo#13093) - chore(deps): update rust crate windows-sys to 0.52 (rust-lang/cargo#13089) - refactor(toml): Decouple logic from schema (rust-lang/cargo#13080) - Have cargo add --optional <dep> create a <dep> = "dep:<dep> feature (rust-lang/cargo#13071) - Add `--public` for `cargo add` (rust-lang/cargo#13046) - chore(deps): update rust crate toml_edit to 0.21.0 (rust-lang/cargo#13088) - chore(deps): update rust crate rusqlite to 0.30.0 (rust-lang/cargo#13087) - test(trim-paths): exercise with real world debugger (rust-lang/cargo#13091) - Fixed uninstall a running binary failed on Windows (rust-lang/cargo#13053) - chore(deps): update rust crate itertools to 0.12.0 (rust-lang/cargo#13086) - Add more options to registry test support. (rust-lang/cargo#13085) - Don't filter on workspace members when scraping doc examples (rust-lang/cargo#13077) - Remove the outdated comment (rust-lang/cargo#13076) - fix(resolver): Remove unused public-deps error handling (rust-lang/cargo#13036) - Fixes error count display is different when there's only one error left (rust-lang/cargo#12484) - fix: reorder `--remap-path-prefix` flags for `-Zbuild-std` (rust-lang/cargo#13065) - remove jobserver env var in some tests (rust-lang/cargo#13072) - doc: clarify different target has different set of `CARGO_CFG_*` values (rust-lang/cargo#13069) - docs: remove review capacity notice in PR template (rust-lang/cargo#13070) - chore(deps): update rust crate openssl to 0.10.60 [security] (rust-lang/cargo#13068) - fix(resolver): De-prioritize no-rust-version in MSRV resolver (rust-lang/cargo#13066)

rustbot assigned ehuss Dec 2, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2023

weihanglo marked this pull request as draft December 2, 2023 05:29

test(install): use TCP connection instead of thread sleep

297b827

This is more robust than `thread::sleep`, ensuring * foo is running before the first `cargo uninstall` call * foo is stopped before the second `cargo uninstall` call

weihanglo force-pushed the running-binary branch from c4a6629 to 297b827 Compare December 2, 2023 06:57

weihanglo marked this pull request as ready for review December 2, 2023 07:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023

bors merged commit 58fb231 into rust-lang:master Dec 2, 2023
20 checks passed

weihanglo deleted the running-binary branch December 2, 2023 14:54

weihanglo mentioned this pull request Dec 2, 2023

Update cargo rust-lang/rust#118541

Merged

rustbot added this to the 1.76.0 milestone Dec 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(install): use TCP connection instead of thread sleep #13099

test(install): use TCP connection instead of thread sleep #13099

weihanglo commented Dec 2, 2023

rustbot commented Dec 2, 2023

weihanglo commented Dec 2, 2023

epage commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023

test(install): use TCP connection instead of thread sleep #13099

test(install): use TCP connection instead of thread sleep #13099

Conversation

weihanglo commented Dec 2, 2023

What does this PR try to resolve?

How should we test and review this PR?

Additional information

rustbot commented Dec 2, 2023

weihanglo commented Dec 2, 2023

epage commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023