feat(cargo-update): --precise to allow yanked versions
#13333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `OptVersionReq::update_precise` to `precise_to` * `OptVersionReq::UpdatePrecise` to `Precise`
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cli-help
weihanglo
commented
Jan 21, 2024
|
Leaving open for feedback on how to emit the warning. But r=me when ready. |
weihanglo
force-pushed
the
precise-yank
branch
from
7eb0ba2
to
c5fb788
Compare
Eh2406
reviewed
Jan 29, 2024
|
Looks good to me, fix the typo and merge. |
weihanglo
force-pushed
the
precise-yank
branch
from
c5fb788
to
17cae8e
Compare
epage
reviewed
Jan 29, 2024
epage
reviewed
Jan 29, 2024
epage
reviewed
Jan 29, 2024
epage
reviewed
Jan 29, 2024
epage
reviewed
Jan 29, 2024
|
(no need to wait on me to approve fixes for any of my comments) |
This is not ideal and we need to track selected yanked versions.
This also tweaks the error message a bit.
weihanglo
force-pushed
the
precise-yank
branch
from
17cae8e
to
caeaaa5
Compare
|
Addressed all the wording suggestions. Thanks! @bors r=Eh2406 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Is #4225 intended to be the tracking issue for this? |
Sort of? I expect a relatively short unstable period then we merge it. I am not sure if everybody is happy about insta-stable. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2024
Update cargo 24 commits in 7bb7b539558dc88bea44cee4168b6269bf8177b0..cdf84b69d0416c57ac9dc3459af80dfb4883d27a 2024-01-20 00:15:32 +0000 to 2024-02-02 19:39:16 +0000 - Apply `-Zpanic-abort-tests` to doctests too (rust-lang/cargo#13388) - Don't print rustdoc command lines on failure by default (rust-lang/cargo#13387) - Ensure `nonzero_exit_code` test isn't affected by developers `RUST_BACKTRACE` setting (rust-lang/cargo#13385) - Add `docsrs` cfg as a well known `--check-cfg` (rust-lang/cargo#13383) - fix(new): Print a note, rather than a comment, for more information (rust-lang/cargo#13371) - Change tests to support changes to suggestion (rust-lang/cargo#13382) - chore(ci): enable m1 runner (rust-lang/cargo#13377) - fix(toml): Improve map/sequence error message (rust-lang/cargo#13376) - fix(diagnostic): Don't panic on empty spans (rust-lang/cargo#13375) - doc: Hide `cargo-fetch` description in offline man page (rust-lang/cargo#13364) - feat: stabilize lockfile v4 (rust-lang/cargo#12852) - fix(new): Print a 'Creating', rather than 'Created' status (rust-lang/cargo#13367) - fix: use spec id instead of name to match package (rust-lang/cargo#13335) - refactor(shell): Use new fancy anstyle API (rust-lang/cargo#13368) - feat(cargo-update): `--precise` to allow yanked versions (rust-lang/cargo#13333) - refactor: remove unnecessary Option in `Freshness::Dirty` (rust-lang/cargo#13361) - doc: Replace version with `latest` for jobserver link (rust-lang/cargo#13366) - test: data layout fix for `x86_64-unknown-none-gnu` (rust-lang/cargo#13362) - docs(ref): Try to improve reg auth docs (rust-lang/cargo#13351) - fix typo of rustbuild, instead of rustuild (rust-lang/cargo#13357) - fix(config): Deprecate non-extension files (rust-lang/cargo#13349) - fix(cli): Improve errors related to cargo script (rust-lang/cargo#13346) - fix list option description starting with uppercase (rust-lang/cargo#13344) - Fix typo in test (rust-lang/cargo#13342)
|
I don't see us learning much from this being unstable and am good with having an FCP on this now. |
|
The only change I can see maybe eventually doing is making yanked versions candidates but making them the lowest priority. So long as we don't close the door on that which I don't think this change does, I'm good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Address #4225
Supports specifying yanked versions via the
--preciseflag ofcargo update.This is still behind
-Zunstable-optionsnightly flag.How should we test and review this PR?
Review this commit by commit.
As Jacob mentioned in #4225 (comment), only indexes in registry sources can be yanked. None of git source, path source, directory source can. It should be pretty safe not checking sources.
The other thing needing a review is the warning. It is pretty slim at this moment, but a big warning can be added if we want to scare people away from using yanked versions 👻.
Additional information