Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused imports on Windows. #13469

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix unused imports on Windows. #13469

merged 1 commit into from
Feb 21, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 21, 2024

These imports were causing a warning on Windows because they are only used in a section that is conditional for Unix.

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2024
@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 21, 2024

📌 Commit 27f84f6 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2024
@bors
Copy link
Collaborator

bors commented Feb 21, 2024

⌛ Testing commit 27f84f6 with merge be41d1e...

@bors
Copy link
Collaborator

bors commented Feb 21, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing be41d1e to master...

@bors bors merged commit be41d1e into rust-lang:master Feb 21, 2024
21 checks passed
@weihanglo weihanglo mentioned this pull request Feb 21, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
@bors
Auto merge of rust-lang#121380 - weihanglo:update-cargo, r=weihanglo
0987e41 
Update cargo

9 commits in 7b7af3077bff8d60b7f124189bc9de227d3063a9..194a60b2952bd5d12ba15dd2577a97eed7d3c587
2024-02-17 14:13:00 +0000 to 2024-02-21 01:53:45 +0000
- fix: remove unused `sysroot_host_libdir` (rust-lang/cargo#13468)
- feat: support `target.<triple>.rustdocflags` officially (rust-lang/cargo#13197)
- Fix unused imports on Windows. (rust-lang/cargo#13469)
- Fix more redundant imports. (rust-lang/cargo#13466)
- test: Remove empty snapshots (rust-lang/cargo#13465)
- chore: Rename `Config` to `GlobalContext` (rust-lang/cargo#13409)
- Fix redundant imports. (rust-lang/cargo#13464)
- feat: respect `rust-version` when generating lockfile (rust-lang/cargo#12861)
- chore(ci): bump CI tools (rust-lang/cargo#13459)

r? ghost
@rustbot rustbot added this to the 1.78.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rustbot @weihanglo @bors @epage