Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/Docs: Dead links and domain hijacking? #1172

Closed
tadghh opened this issue Aug 5, 2024 · 4 comments · Fixed by #1173
Closed

Issue/Docs: Dead links and domain hijacking? #1172

tadghh opened this issue Aug 5, 2024 · 4 comments · Fixed by #1173

Comments

@tadghh
Copy link

tadghh commented Aug 5, 2024

The "Compile-time Requirements" section contains a few dead links. The Win-builds link now goes to someones blog "if im wrong my bad!" when I think it should lead to here https://github.com/alex85k/winbuilds/blob/master/README.md

Another issue is the "here" link for MSYS2, the section/header it refers to no longer exists https://github.com/rust-lang/rust#building-on-windows.
The following looks like a good replacement.
https://github.com/rust-lang/rust/blob/master/INSTALL.md#building-on-windows

@tadghh
Copy link
Author

tadghh commented Aug 5, 2024

@NobodyXu
Copy link
Collaborator

NobodyXu commented Aug 6, 2024

Thank you, I'll open a PR immediately for this

NobodyXu added a commit that referenced this issue Aug 6, 2024
@tadghh
Copy link
Author

tadghh commented Aug 6, 2024

Thank you, I'll open a PR immediately for this

You removed the new win-builds link from your first commit. Was this on pourpose?

@NobodyXu
Copy link
Collaborator

NobodyXu commented Aug 6, 2024

Yes, @ChrisDenton asked me to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants