Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic safety issue in StderrForwarder #1079

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Fix panic safety issue in StderrForwarder #1079

merged 5 commits into from
Jun 7, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Jun 2, 2024

Fixed #1036

ChrisDenton
ChrisDenton approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My only nit is that I don't think this is allow is necessary any more:

cc-rs/src/command_helpers.rs

Line 93 in ca1f5f9

#[allow(clippy::uninit_vec)]

@NobodyXu NobodyXu merged commit 083c3c4 into main Jun 7, 2024
48 checks passed
@NobodyXu NobodyXu deleted the NobodyXu-patch-3 branch June 7, 2024 22:19
@github-actions github-actions bot mentioned this pull request Jun 23, 2024
Merged
@workingjubilee
Copy link
Member

thanks for patching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

@thomcc thomcc Awaiting requested review from thomcc

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible panic safety issue in StderrForwarder
3 participants
@NobodyXu @workingjubilee @ChrisDenton