Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritize NoSpace error more #729

Merged
merged 3 commits into from
Aug 25, 2024
Merged

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented May 31, 2024

Replacement for #715

adjust the prioritization of NoSpace

After this it will be prioritized above

  • DependsOn
  • CompilerError
  • NetworkAccess
  • CompilerDiagnosticChange

The later two are already spurious-regressions so only the reason will change.
The former two would previously result in a regression but now would be spurious-regressions.
I think this change is reasonable as no space will likely be the cause for the compiler error or the error in the dependency.

include the spurious regressions in the retry-regressed-list.txt

Spurious failures might hide actual regressions, this gives them another chance at showing actual regressions.
Further more spurious regressions are usually not too many and re-running will in a lot of cases resolve the spurious failure.

Sort some CommandError::IO(_) into as better FailureReason

@Skgland
Copy link
Contributor Author

Skgland commented May 31, 2024

Looks like time 0.3.30 is broken

   Compiling memoffset v0.9.0
error[E0282]: type annotations needed for `Box<_>`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

    Checking bitflags v2.4.1

@bors
Copy link
Collaborator

bors commented Aug 24, 2024

☔ The latest upstream changes (presumably #732) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Aug 25, 2024

☔ The latest upstream changes (presumably #734) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2024

📌 Commit 397f3f0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 25, 2024

⌛ Testing commit 397f3f0 with merge bdd7be9...

@bors
Copy link
Collaborator

bors commented Aug 25, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing bdd7be9 to master...

@bors bors merged commit bdd7be9 into rust-lang:master Aug 25, 2024
3 checks passed
@Skgland Skgland deleted the no-space-left2 branch August 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants