Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded credentials path with cargo docs link #6958

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

federicomenaquintero
Copy link
Contributor

https://crates.io/settings/tokens incorrectly says ~/.cargo/credentials, it's missing the .toml in the filename.

@Turbo87
Copy link
Member

Turbo87 commented Aug 11, 2023

for context: #5730

@LawnGnome
Copy link
Contributor

OK, so if I'm reading the history correctly:

  • Cargo added support for credentials.toml (with the extension) in 1.39.0 (November 2019).
  • Cargo has created credentials.toml (with the extension) by default since 1.68.0 (March this year).

I guess my question is which of credentials and credentials.toml wins — if a user has a pre-existing credentials, and we tell them to add things to credentials.toml, is that going to break things?

Feels like it might be a little soon to make this change, but I'm interested in if anyone on the @rust-lang/cargo team has an opinion here?

@weihanglo
Copy link
Member

weihanglo commented Aug 11, 2023

I guess my question is which of credentials and credentials.toml wins — if a user has a pre-existing credentials, and we tell them to add things to credentials.toml, is that going to break things?

Nothing gonna be broken. credentials.toml would be ignored in that case.

Maybe just say it being saved in a local credential file and link to where The Cargo Book mentions it?

BTW just created rust-lang/cargo#12479 to clarify the situation. Thanks for the summary @LawnGnome :)

@Turbo87
Copy link
Member

Turbo87 commented Aug 13, 2023

Maybe just say it being saved in a local credential file and link to where The Cargo Book mentions it?

that seems like a good idea to me. @federicomenaquintero could you amend the pull request accordingly? :)

@Turbo87 Turbo87 added the C-documentation 📜 Category: Documentation of crates.io itself label Aug 13, 2023
@Turbo87 Turbo87 changed the title Fix the name of ~/.cargo/credentials.toml Replace hardcoded credentials path with cargo docs link Sep 12, 2023
@Turbo87 Turbo87 enabled auto-merge (squash) September 12, 2023 19:23
@Turbo87 Turbo87 merged commit aa31a90 into rust-lang:main Sep 12, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-documentation 📜 Category: Documentation of crates.io itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants