Use set() over take() to ensure sink is dropped

rust-lang · Feb 15, 2019 · adedad1 · adedad1
1 parent 21f45bd
commit adedad1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/futures-util/src/stream/forward.rs b/futures-util/src/stream/forward.rs
@@ -85,7 +85,7 @@ where
                 Poll::Ready(None) => {
                     try_ready!(self.as_mut().sink().as_pin_mut().expect(INVALID_POLL)
                                    .poll_flush(lw));
-                    let _ = self.as_mut().sink().as_pin_mut().take().unwrap();
+                    self.as_mut().sink().set(None);
                     return Poll::Ready(Ok(()))
                 }
                 Poll::Pending => {