Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV of futures-util to 1.41 #2405

Merged
merged 1 commit into from
May 1, 2021
Merged

Bump MSRV of futures-util to 1.41 #2405

merged 1 commit into from
May 1, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 1, 2021

This bumps MSRV of futures-util and its dependents (futures, futures-executor, futures-test).

This is because the latest memchr (dependency of futures-util) requires Rust 1.41.

https://github.com/rust-lang/futures-rs/runs/2480445418?check_suite_focus=true

error[E0658]: non exhaustive is an experimental feature
   --> /home/runner/.cargo/registry/src/gitpro.ttaallkk.top-1ecc6299db9ec823/memchr-2.4.0/src/memmem/prefilter/mod.rs:152:1
    |
152 | #[non_exhaustive]
    | ^^^^^^^^^^^^^^^^^
    |

Also, the motivation behind Rust 1.41 being set as memchr's new MSRV seems reasonable to me:

BurntSushi/memchr@952717e

This also bumps the MSRV to Rust 1.41, which is what is currently in
Debian stable.

Users can continue to use the old compiler by downgrading memchr. However, I don't think futures-util itself needs to do that as I think 1.41 is a reasonable MSRV (it was released over a year ago).

@taiki-e taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label May 1, 2021
@taiki-e taiki-e merged commit f02a451 into rust-lang:master May 1, 2021
@taiki-e taiki-e deleted the msrv branch May 1, 2021 05:23
@taiki-e taiki-e mentioned this pull request May 7, 2021
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant