Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustfmt check to CI #2421

Merged
merged 2 commits into from
May 7, 2021
Merged

Add rustfmt check to CI #2421

merged 2 commits into from
May 7, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 7, 2021

  • Add rustfmt check to CI
  • Format modules defined inside macros

@taiki-e
Add rustfmt check to CI
e2ab424
@taiki-e
Format modules defined inside macros
9933fb3 
`cargo fmt` cannot recognize modules defined inside macros.
@taiki-e taiki-e mentioned this pull request May 7, 2021
Merged
@taiki-e taiki-e merged commit 5691066 into master May 7, 2021
@taiki-e taiki-e deleted the fmt branch May 7, 2021 14:45
@taiki-e taiki-e mentioned this pull request May 7, 2021
Merged
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 7, 2021
taiki-e
taiki-e commented May 8, 2021
View reviewed changes
tools/fmt.sh

# shellcheck disable=SC2046
if [[ -z "${CI:-}" ]]; then
(
Copy link
Member Author

@taiki-e taiki-e May 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I added these extra parentheses...

EDIT: filed #2425

@taiki-e taiki-e mentioned this pull request May 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.3-backport: completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e