Remove drain-on-drop behavior from DrainFilter #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the8472
force-pushed
the
dont-drain-on-drop
branch
from
28a13cf
to
6628f6d
Compare
|
The ACP has been approved so this should be ready to review. |
This was referenced Jan 15, 2023
|
Ah, I forgot that there was also a request to rename the API in std. So this could be made non-breaking in hashbrown by adding the new behavior under the new name and keeping the old impl. |
|
I think it's fine to just make it a breaking change. I am planning to make a major version bump anyways. |
the8472
force-pushed
the
dont-drain-on-drop
branch
from
3f9a5a2
to
76fe28c
Compare
the8472
force-pushed
the
dont-drain-on-drop
branch
from
76fe28c
to
a0ab1de
Compare
|
Ready for review. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2023
Don't drain-on-drop in DrainFilter impls of various collections. This removes drain-on-drop behavior from various unstable DrainFilter impls (not yet for HashSet/Map) because that behavior [is problematic](rust-lang#43244 (comment)) (because it can lead to panic-in-drop when user closures panic) and may become forbidden if [this draft RFC passes](rust-lang/rfcs#3288). closes rust-lang#101122 [ACP](rust-lang/libs-team#136) affected tracking issues * rust-lang#43244 * rust-lang#70530 * rust-lang#59618 Related hashbrown update: rust-lang/hashbrown#374
oli-obk
pushed a commit
to oli-obk/miri
that referenced
this pull request
Jun 15, 2023
Don't drain-on-drop in DrainFilter impls of various collections. This removes drain-on-drop behavior from various unstable DrainFilter impls (not yet for HashSet/Map) because that behavior [is problematic](rust-lang/rust#43244 (comment)) (because it can lead to panic-in-drop when user closures panic) and may become forbidden if [this draft RFC passes](rust-lang/rfcs#3288). closes #101122 [ACP](rust-lang/libs-team#136) affected tracking issues * #43244 * #70530 * #59618 Related hashbrown update: rust-lang/hashbrown#374
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Aug 24, 2023
Don't drain-on-drop in DrainFilter impls of various collections. This removes drain-on-drop behavior from various unstable DrainFilter impls (not yet for HashSet/Map) because that behavior [is problematic](rust-lang/rust#43244 (comment)) (because it can lead to panic-in-drop when user closures panic) and may become forbidden if [this draft RFC passes](rust-lang/rfcs#3288). closes #101122 [ACP](rust-lang/libs-team#136) affected tracking issues * #43244 * #70530 * #59618 Related hashbrown update: rust-lang/hashbrown#374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for hashbrown but not for std because in std the drain impl is still unstable.
This is part of stdlib ACP 136.