show warning when Stacked Borrows skips a reborrow due to 'extern type' #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
RalfJung
force-pushed
the
extern-type-reborrow
branch
from
ad242d2
to
cf2ce6c
Compare
RalfJung
commented
Jun 29, 2024
RalfJung
added
the
S-waiting-on-author
RalfJung
force-pushed
the
extern-type-reborrow
branch
from
cf2ce6c
to
b6dd892
Compare
|
With rust-lang/rust#127859, this doesn't show any warnings for standard library code any more. :) @rust-lang/miri what do you think? |
saethlin
reviewed
Jul 24, 2024
|
I think you want to update the PR description a bit. I support having a warning for this, and won't complain much if you prefer your current wording :p |
RalfJung
force-pushed
the
extern-type-reborrow
branch
from
b6dd892
to
9aa0893
Compare
|
All right, let's go with this then. :) @bors r=saethlin |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this happens, we can't actually be sure to catch all bugs -- LLVM will still get a
noaliasbut Miri can't do reborrowing. That's not good.