const_eval: update for const_mut_refs and const_refs_to_cell stabilization #1590
Conversation
src/const_eval.md
Outdated
| * All forms of [borrow]s, including raw borrows, with one limitation: | ||
| mutable borrows and shared borrows to values with interior mutability | ||
| are only allowed to refer to *transient* places. A place is *transient* | ||
| if it will be deallocated before the end of evaluating the current constant item. |
There was a problem hiding this comment.
Given that not all const contexts are syntactically items, though they are desugared that way, would it be better here to say "end of evaluating the current constant context"?
There was a problem hiding this comment.
If "evaluating a const context" is meaningful, then yeah that would work. It sounds a bit odd to me, how can you evaluate a "context"? The context is what the evaluation occurs in.
No strong preference either way.
There was a problem hiding this comment.
Maybe "evaluating the contents of the current const context"? Open to other ideas.
The main thrust is that const context is something we define and seems to be closer to what we mean here.
There was a problem hiding this comment.
"evaluating the item" is how we call it in the compiler so I got used to that one. ;)
ehuss
added
the
S-waiting-on-stabilization
RalfJung
force-pushed
the
const-mut-refs
branch
from
aa1dab6
to
ace105a
Compare
This is the reference PR accompanying rust-lang/rust#129195.
Fixes rust-lang/rust#57349
Fixes rust-lang/rust#80384