Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial cleanup on expressions (part 1) #967

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Commits on Feb 27, 2021

  1. Editorial cleanup on expressions (part 1)

    * Use "the syntax of" uniformly.
    * Use asterisks for all defined terms.
    * Define more terms, espcially in the syntax section.
    ** Reword things so that definitions are generally first.
    ** I did not necessarily go with the best wording; the idea is to
       improve, not perfect. I still need to dedicate time to each
       expressions individually.
    * Remove usage of "the compiler" and "Rust".
    ** This also involved rewording.
    ** How to deal with closure types and closure expressions is gonna be
       an interesting question to solve. I avoided solving it here.
    * Remove non-normative information or put them in a `Note`.
    * A few added section headers
    * Move links to the bottom
    
    Note that I've left quite a few nonsensical statements alone, such as
    any that use "denote". They'll be treated separately.
    
    About halfway through the list of expressions and this PR is getting
    large. So I'm gonna cut this one here, stopping at grouped expressions
    in the alphabetical list.
    Havvy committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    a065d3e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Apply suggestions from code review

    Co-authored-by: Eric Huss <eric@huss.org>
    Havvy and ehuss committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    3da65a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. More editorial changes to expressions

    * Go back to calling the syntactic elements "expressions", but name
      them operands afterwards.
    * Use "called XYZ" to name something in syntax.
    * Trade out a few uses of expressions using letters for operand names
      for the actual operand names.
    * Pick arbitrary names for the operands. I don't like some of them, but
      they're not set in stone.
    * Say they're not set in stone in the main expressions chapter.
    Havvy committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    31dc83f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Apply suggestions from code review

    Co-authored-by: Eric Huss <eric@huss.org>
    Havvy and ehuss committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2367297 View commit details
    Browse the repository at this point in the history