Fix ambiguous phrasing in 8.2.13 in paragraph on closure traits #991
Conversation
| The closure will also implement the closure traits [`Send`](../special-types-and-traits.md#send) and/or [`Sync`](../special-types-and-traits.md#sync) if all of its captured types do. | ||
| Closure traits allow functions to accept closures using generics, even though the exact types can't be named. |
There was a problem hiding this comment.
I wouldn't add "the closure traits" for Send/Sync. "Closure traits" specifically refers to Fn, FnMut, and FnOnce. The other traits that closures may implement (send/sync/copy/clone) are just extras, and are not directly related to allowing use as function parameters.
I'm not sure why they are even called closure traits, since they are just the general call traits which are used for things other than closures. And I also question why it explicitly says "using generics", since closures can also be passed as trait objects.
Since the closure type chapter uses a clearer term ("call traits"), I would change it to use that phrasing, and change the last sentence to something like "The call traits allow functions to accept closures as parameters, even though…".
|
Oh, I forgot. This will be rewritten as part of #967. Perhaps you could take a look at that PR and see if it is clearer there? |
ehuss
added
the
S-waiting-on-author
|
I'm going to close this since this section has been rewritten, which I think has a bit clearer wording. |
|
Sorry I failed to respond before, and thanks for clarifying the text |
Addresses #983.
8.2.13 contains a paragraph of three sentences, in which the first sentence talks about the set of all closure traits, the second sentence talks about the specific closure traits
sendandsync, and the third sentence uses the phrase "these traits". In the third sentence it is unclear if the referent of "these traits" is closure traits (first sentence), the specific closure traits described in the second sentence, or nothing at all (IE it could mean "these characteristics" in the informal English sense).This patch clarifies the text so that it is totally clear the two traits in sentence two are a subset of closure traits and totally clear that "these traits" in sentence three refers to "closure traits". I didn't get any answers in #983 but that is my best reasonable guess what the text means. Obviously only merge this if this is actually the text's intent…!