RFC: Prevent lint changes being a breaking change #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new flag to the compiler, `--cap-lints`, which set the maximum possible lint level for the entire crate (and cannot be overridden). Cargo will then pass `--cap-lints allow` to all upstream dependencies when compiling code.
alexcrichton
added
the
T-dev-tools
| # Drawbacks | ||
|
|
||
| This RFC adds surface area to the command line of the compiler with a relatively | ||
| obscure option `--cap-lints`. The option will almost never be passed by anything |
There was a problem hiding this comment.
We could hide it away in e.g. -Z to keep it from polluting --help.
There was a problem hiding this comment.
We do currently kinda have this already, the --help --verbose page is a little longer than --help. I'd also prefer to continue to consider -Z as "unstable flags", aka flags that Cargo should avoid.
|
Big 👍 from me. |
|
+1 from me. |
| ``` | ||
|
|
||
| For example when `--cap-lints allow` is passed, all instances of `#[warn]`, | ||
| `#[deny]`, and `#[forbid] are ignored. If, however `--cap-lints warn` is passed |
There was a problem hiding this comment.
(`#[forbid] needs a closing backtick)
|
After being bit hard by |
|
👍 Alex! |
|
The tools team has decided to place this RFC in its final comment period. |
alexcrichton
added
the
final-comment-period
brson
added a commit
to brson/rust
that referenced
this pull request
Jul 20, 2015
This reverts commit 00130cf. As mentioned in a regression report[1], this caused a notable amount of breakage. Because there's a plan to mitigate[2] this type of breakage, I'm reverting this until then. [1]: https://internals.rust-lang.org/t/new-crater-reports-1-1-stable-vs-beta-2015-07-10-and-nightly-2015-07-10/2358 [2]: rust-lang/rfcs#1193
This was referenced Jul 20, 2015
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 21, 2015
This reverts commit 00130cf. As mentioned in a regression report[1], this caused a notable amount of breakage. Because there's a plan to mitigate[2] this type of breakage, I'm reverting this until then. [1]: https://internals.rust-lang.org/t/new-crater-reports-1-1-stable-vs-beta-2015-07-10-and-nightly-2015-07-10/2358 [2]: rust-lang/rfcs#1193
|
The consensus of the tools team is to merge this RFC, so I'm going to do so! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jul 29, 2015
This commit is an implementation of [RFC 1193][rfc] which adds the ability to the compiler to cap the lint level for the entire compilation session. This flag will ensure that no lints will go above this level, and Cargo will primarily use this flag passing `--cap-lints allow` to all upstream dependencies. [rfc]: rust-lang/rfcs#1193 Closes rust-lang#27259
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 29, 2015
This commit is an implementation of [RFC 1193][rfc] which adds the ability to the compiler to cap the lint level for the entire compilation session. This flag will ensure that no lints will go above this level, and Cargo will primarily use this flag passing `--cap-lints allow` to all upstream dependencies. [rfc]: rust-lang/rfcs#1193 Closes #27259
Centril
added
A-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new flag to the compiler,
--cap-lints, which set the maximum possiblelint level for the entire crate (and cannot be overridden). Cargo will then pass
--cap-lints allowto all upstream dependencies when compiling code.Fixes #1029.
Rendered