target spec: remove /etc/rustc as default path #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC specifies that if RUST_TARGET_PATH is unset then the default is /etc/rustc but this won't work on all systems (e.g. Windows) and the Rust compiler never actually implemented this behavior so remove it from the RFC. closes rust-lang/rust#31117 Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
|
This solves a problem, in that it lets distros patch in custom target specs without patching the source, but I agree this is not the way to do it, since it's unix specific and would be the only place rustc knows about |
|
@brson I was thinking making the rustlib directory the default directory searched? That could hopefully work cross platform? |
|
I'm going to merge this because it's less so much a full-fledged RFC but rather an update to match the current implementation. The custom target spec RFC unfortunately wasn't scrutinized for stabilization in the 1.0 push, so it's been largely grandfathered in. Nowadays we would likely require an RFC to re-add this behavior. Thanks for the keen eye @cardoe! cc @rust-lang/tools |
alexcrichton
added a commit
that referenced
this pull request
Jan 22, 2016
target spec: remove /etc/rustc as default path
cardoe
added a commit
to cardoe/rust
that referenced
this pull request
Apr 9, 2016
The path `/etc/rustc/` is not the default last entry in RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 14, 2016
…hton librustc_back: fix incorrect comment about RUST_TARGET_PATH The path `/etc/rustc/` is not the default last entry in RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Centril
added
the
not-rfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC specifies that if RUST_TARGET_PATH is unset then the default is
/etc/rustc but this won't work on all systems (e.g. Windows) and the
Rust compiler never actually implemented this behavior so remove it from
the RFC. closes rust-lang/rust#31117
Signed-off-by: Doug Goldstein cardoe@cardoe.com