Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode: Please disable code completion when using _ in pattern #12592

Closed
msrd0 opened this issue Jun 20, 2022 · 1 comment · Fixed by #12596
Closed

VSCode: Please disable code completion when using _ in pattern #12592

msrd0 opened this issue Jun 20, 2022 · 1 comment · Fixed by #12596
Assignees
@Veykril
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now

Comments

@msrd0
Copy link

msrd0 commented Jun 20, 2022

When using _ in a pattern, I immediately get the following completely useless code completion:

image

Please disable that code completion.
@lnicola lnicola added A-completion autocompletion S-actionable Someone could pick this issue up and work on it right now C-bug Category: bug labels Jun 20, 2022
@lnicola
Copy link
Member

lnicola commented Jun 20, 2022 •
edited
Loading

This looks like a recent regression (newer than 7ca5d16).

@Veykril Veykril self-assigned this Jun 20, 2022
@Veykril Veykril mentioned this issue Jun 20, 2022
Merged
bors added a commit that referenced this issue Jun 20, 2022
@bors
Auto merge of #12596 - Veykril:completions, r=Veykril
827654c 
fix: Don't trigger pattern completions when typing a wildcard pattern

Fixes #12592
@bors bors closed this as completed in 9fdfa9f Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't trigger pattern completions when typing a wildcard pattern Veykril/rust-analyzer
3 participants
@lnicola @Veykril @msrd0