Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve docs generation assist #12303

Merged
merged 1 commit into from
May 18, 2022
Merged

feat: Improve docs generation assist #12303

merged 1 commit into from
May 18, 2022

Conversation

jonas-schievink
Copy link
Contributor

  • Split into 2 assists: one generates basic docs structure, but no example, one generates an example
  • Fix section ordering (the example comes last)
  • Allow generating docs for private functions
  • Expand len to length when generating an intro sentence

@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented May 18, 2022

📌 Commit 93b62db has been approved by jonas-schievink

@bors
Copy link
Collaborator

bors commented May 18, 2022

⌛ Testing commit 93b62db with merge b6b17c7...

@bors
Copy link
Collaborator

bors commented May 18, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing b6b17c7 to master...

@bors bors merged commit b6b17c7 into rust-lang:master May 18, 2022
@jonas-schievink jonas-schievink deleted the improve-generate-docs-assist branch May 18, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-schievink @bors