Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustc_pattern_analysis to 0.42.0 #16778

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Nadrieril
Copy link
Member

There was an important API change in 0.41.0, and (hopefully) a fix for #16774 in 0.42.0.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2024
@@ -88,7 +88,7 @@ ra-ap-rustc_lexer = { version = "0.40.0", default-features = false }
ra-ap-rustc_parse_format = { version = "0.40.0", default-features = false }
ra-ap-rustc_index = { version = "0.40.0", default-features = false }
ra-ap-rustc_abi = { version = "0.40.0", default-features = false }
ra-ap-rustc_pattern_analysis = { version = "0.40.0", default-features = false }
ra-ap-rustc_pattern_analysis = { version = "0.42.0", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump the other ra-ap-rustc crates here as well? Otherwise we get duped dependencies of those and usually they don't contain any abi breakage

Copy link
Member Author

@Nadrieril Nadrieril Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, there was only a tiny API change

@lnicola
Copy link
Member

lnicola commented Mar 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

📌 Commit e31484c has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

⌛ Testing commit e31484c with merge bbb441e...

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing bbb441e to master...

@bors bors merged commit bbb441e into rust-lang:master Mar 7, 2024
11 checks passed
@Nadrieril Nadrieril deleted the update-pat-ana branch March 7, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants