Skip to content

Commit

Permalink
Auto merge of #790 - servo:fitzgen-patch-1, r=emilio
Browse files Browse the repository at this point in the history
Minimal test cases don't have `#include`s

The inclusion of an `#include` means that the test case

* is not minimal, and
* is harder to reproduce the bug with, since not everyone has the same headers (or versions of headers) on their system.

r? @emilio
  • Loading branch information
bors-servo committed Jul 6, 2017
2 parents 78e7546 + 1f323cf commit 3bb248b
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
### Input C/C++ Header

```C++
// Insert your (minimal) C/C++ header here.
// Insert your minimal C or C++ header here.
//
// It should *NOT* have any `#include`s! Not all systems have the same header
// files, and therefore any `#include` harms reproducibility. Additionally,
// the test case isn't minimal since the included file almost assuredly
// contains things that aren't necessary to reproduce the bug, and makes
// tracking it down much more difficult. If necessary, see
// https://github.com/servo/rust-bindgen/blob/master/CONTRIBUTING.md#using-creduce-to-minimize-test-cases
```

### Bindgen Invocation
Expand Down

0 comments on commit 3bb248b

Please sign in to comment.