shadow_unrelated is using idents from RHS of assignment

[lopopolo]

Clippy outputs these warnings:

warning: `state
            .parser
            .as_mut()
            .ok_or(InterpreterExtractError::new())?` is being shadowed
  --> artichoke-backend/src/parser.rs:39:22
   |
39 |           let parser = state
   |  ______________________^
40 | |             .parser
41 | |             .as_mut()
42 | |             .ok_or(InterpreterExtractError::new())?;
   | |___________________________________________________^
   |
note: initialization happens here
  --> artichoke-backend/src/parser.rs:39:22
   |
39 |           let parser = state
   |  ______________________^
40 | |             .parser
41 | |             .as_mut()
42 | |             .ok_or(InterpreterExtractError::new())?;
   | |___________________________________________________^
note: previous binding is here
  --> artichoke-backend/src/parser.rs:38:21
   |
38 |         let state = self.state.as_mut().ok_or(InterpreterExtractError::new())?;
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#shadow_unrelated

warning: `u16::try_from(new)
            .map_err(|_| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?` is being shadowed
  --> artichoke-backend/src/state/parser.rs:68:21
   |
68 |           let store = u16::try_from(new)
   |  _____________________^
69 | |             .map_err(|_| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?;
   | |________________________________________________________________________________^
   |
note: initialization happens here
  --> artichoke-backend/src/state/parser.rs:68:21
   |
68 |           let store = u16::try_from(new)
   |  _____________________^
69 | |             .map_err(|_| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?;
   | |________________________________________________________________________________^
note: previous binding is here
  --> artichoke-backend/src/state/parser.rs:65:19
   |
65 |           let new = old
   |  ___________________^
66 | |             .checked_add(val)
67 | |             .ok_or_else(|| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?;
   | |__________________________________________________________________________________^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#shadow_unrelated

For this code:

    fn add_fetch_lineno(&mut self, val: usize) -> Result<usize, Self::Error> {
        let state = self.state.as_mut().ok_or(InterpreterExtractError::new())?;
        let parser = state
            .parser
            .as_mut()
            .ok_or(InterpreterExtractError::new())?;
        let lineno = parser.add_fetch_lineno(val)?;
        Ok(lineno)
    }

and

    pub fn add_fetch_lineno(&mut self, val: usize) -> Result<usize, IncrementLinenoError> {
        let old = usize::from(unsafe { self.context.as_ref() }.lineno);
        let new = old
            .checked_add(val)
            .ok_or_else(|| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?;
        let store = u16::try_from(new)
            .map_err(|_| IncrementLinenoError::Overflow(usize::from(u16::MAX)))?;
        unsafe {
            self.context.as_mut().lineno = store;
        }
        Ok(new)
    }

I expected to see this happen: No errors, as in Rust 1.46.0

Meta

• cargo clippy -V: clippy 0.0.212 (18bf6b4f0 2020-10-07)
• rustc -Vv:

  rustc 1.47.0 (18bf6b4f0 2020-10-07)
  binary: rustc
  commit-hash: 18bf6b4f01a6feaf7259ba7cdae58031af1b7b39
  commit-date: 2020-10-07
  host: x86_64-apple-darwin
  release: 1.47.0
  LLVM version: 11.0
  

[dpathakj]

Here's a minimal example of what I think might be the same thing, using the recently landed #![feature(destructuring_assignment)]:

#[warn(clippy::shadow_unrelated)]
fn multiple_assignment_produces_false_positive() {
    let mut n = 0;
    let mut b = false;
    loop {
        (n, b) = f(n, b); // warning: `b` is being shadowed - doesn't warn about `n`, though
    }
}

fn f(a: usize, b: bool) -> (usize, bool) {
    (a + 1, !b)
}

With a single assignment, there's no warning:

#[warn(clippy::shadow_unrelated)]
fn single_assignment_produces_true_negative() {
    let mut n = 0;
    loop {
        n = f_prime(n); // no warning about `n` being shadowed
    }
}

fn f_prime(a: usize) -> usize {
    a + 1
}

[atlv24]

Would this be the same issue as

#[warn(clippy::shadow_unrelated)]
pub fn example(v: &mut u32) -> u32 {
    let s;
    (*v, s) = (0, 0);
    //   ^ `s` shadows a previous, unrelated binding
    s
}

Or should I open a new issue? Key difference is the second var is an initialization not a mutation.

[llogiq]

Clippy doesn't see a difference between delayed init and mutation, so I don't think a new issue is necessary.