Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lint stacked_if_match #13304

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

promptkp
Copy link

fixes #12483


changelog: new [stacked_if_match] lint against if if and match match

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 25, 2024
@bors
Copy link
Collaborator

bors commented Aug 28, 2024

☔ The latest upstream changes (presumably #11476) made this pull request unmergeable. Please resolve the merge conflicts.

@alex-semenyuk
Copy link
Member

In theory cases with match if and if match should work? I would be nice to have examples what happens in this cases

@promptkp
Copy link
Author

promptkp commented Sep 1, 2024

Hi @alex-semenyuk, thank you for the comment. To prevent overlinting, stacked_if_match only lints against if if and match match. I'll add additional test cases for match if and if match.

Note: this is my first contribution to Clippy, so if there's a faster/cleaner way to implement this, please let me know!

@bors
Copy link
Collaborator

bors commented Sep 3, 2024

☔ The latest upstream changes (presumably #13247) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban Stacked if's
5 participants