Fix false positive in empty_line_after_outer_attr #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a single line block comment will break this...? |
oli-obk
reviewed
Mar 30, 2018
clippy_lints/src/utils/mod.rs
Outdated
| let mut without = vec![]; | ||
|
|
||
| // naive approach for block comments | ||
| let mut inside_comment = false; |
There was a problem hiding this comment.
I think this needs to be a counter, because in rust you can nest block comments
|
We should probably move this lint to the nursery group for now. |
Before, when you had a block comment between an attribute and the following item like this: ```rust \#[crate_type = "lib"] /* */ pub struct Rust; ``` It would cause a false positive on the lint, because there is an empty line inside the block comment. This makes sure that basic block comments are detected and removed from the snippet that was created before.
From the clippy side it's difficult to detect empty lines between an attributes and the following item because empty lines and comments are not part of the AST. The parsing currently works for basic cases but is not perfect and can cause false positives. Maybe libsyntax 2.0 will fix some of the problems around attributes but comments will probably be never part of the AST so we would still have to do some manual parsing.
phansch
force-pushed
the
fix_another_false_positive
branch
from
38aaea9
to
db1ec44
Compare
|
I fully agree about moving it to the nursery 👍 @CAD97 I couldn't break with a single line block comment. I added an additional test for #[crate_type = "lib"]
/* test */
pub struct T;which doesn't break it. Did you have something else in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when you had a block comment between an attribute and the
following item like this:
It would cause a false positive on the lint, because there is an empty
line inside the block comment.
This makes sure that basic block comments are detected and removed from
the snippet that was created before.
Fixes #2583