needless bool lint suggestion is wrapped in brackets if it is an "els… #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e" clause of an "if-else" statement
oli-obk
reviewed
Jan 21, 2019
clippy_lints/src/needless_bool.rs
Outdated
|
|
||
| if let rustc::hir::Node::Expr(e) = parent_node { | ||
| if let ExprKind::If(_,_,_) = e.node { | ||
| return true; |
There was a problem hiding this comment.
Rustfmt on travis got hung up on this single space
Suggested change
| return true; | |
| return true; |
phansch
added
the
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 0a0792e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 21, 2019
…li-obk needless bool lint suggestion is wrapped in brackets if it is an "els… …e" clause of an "if-else" statement
|
@bors r- travis' rustfmt run is still unhappy |
oli-obk
reviewed
Jan 21, 2019
|
So, other than rustfmt issues, this looks good to me. I opened #3683 for future improvements of preexisting issues that I saw while reviewing your PR. |
Co-Authored-By: g-bartoszek <grzegorz.bartoszek@thaumatec.com>
|
@bors r+ Thanks! |
|
📌 Commit 34785a1 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 21, 2019
…li-obk needless bool lint suggestion is wrapped in brackets if it is an "els… …e" clause of an "if-else" statement
|
☀️ Test successful - checks-travis, status-appveyor |
|
Yes. I closed it. You can add "fixes #3481" to the main message in a pull request to make sure that merging your pull request automatically closes the referenced issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e" clause of an "if-else" statement