Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make_return" and "blockify" convenience methods, fixes #3683 #3684

Merged
merged 1 commit into from
Jan 22, 2019
Merged

"make_return" and "blockify" convenience methods, fixes #3683 #3684

merged 1 commit into from
Jan 22, 2019

Conversation

g-bartoszek
Copy link

…ed them in "needless_bool".

@oli-obk
Copy link
Contributor

oli-obk commented Jan 22, 2019

@bors r+

That was quick, thanks!

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

📌 Commit 0f5c43a has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

⌛ Testing commit 0f5c43a with merge f430197...

bors added a commit that referenced this pull request Jan 22, 2019
@bors
Auto merge of #3684 - g-bartoszek:sugg-snippet-modifications, r=oli-obk
f430197 
"make_return" and "blockify" convenience methods, fixes #3683

…ed them in "needless_bool".
@flip1995
Copy link
Member

@bors rollup

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Jan 22, 2019
@flip1995
Rollup merge of rust-lang#3684 - g-bartoszek:sugg-snippet-modificatio…
1e672af 
…ns, r=oli-obk

"make_return" and "blockify" convenience methods, fixes rust-lang#3683

…ed them in "needless_bool".
@flip1995 flip1995 mentioned this pull request Jan 22, 2019
Closed
@bors
Copy link
Collaborator

bors commented Jan 22, 2019

💔 Test failed - checks-travis

bors added a commit that referenced this pull request Jan 22, 2019
@bors
Auto merge of #3686 - flip1995:rollup, r=flip1995
09397d9 
Rollup of 4 pull requests

Successful merges:

 - #3582 (Add assert(true) and assert(false) lints)
 - #3679 (Fix automatic suggestion on `use_self`.)
 - #3684 ("make_return" and "blockify" convenience methods, fixes #3683)
 - #3685 (Rustup)

Failed merges:

r? @ghost
@phansch
Copy link
Member

phansch commented Jan 22, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

📌 Commit 0f5c43a has been approved by phansch

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

⌛ Testing commit 0f5c43a with merge e71c8bf...

bors added a commit that referenced this pull request Jan 22, 2019
@bors
Auto merge of #3684 - g-bartoszek:sugg-snippet-modifications, r=phansch
e71c8bf 
"make_return" and "blockify" convenience methods, fixes #3683

…ed them in "needless_bool".
@bors bors mentioned this pull request Jan 22, 2019
Merged
@bors
Copy link
Collaborator

bors commented Jan 22, 2019

💥 Test timed out

@phansch
Copy link
Member

phansch commented Jan 22, 2019

@bors retry

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

⌛ Testing commit 0f5c43a with merge a069320...

bors added a commit that referenced this pull request Jan 22, 2019
@bors
Auto merge of #3684 - g-bartoszek:sugg-snippet-modifications, r=phansch
a069320 
"make_return" and "blockify" convenience methods, fixes #3683

…ed them in "needless_bool".
@bors
Copy link
Collaborator

bors commented Jan 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing a069320 to master...

@bors bors merged commit 0f5c43a into rust-lang:master Jan 22, 2019
@g-bartoszek g-bartoszek deleted the sugg-snippet-modifications branch January 22, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@g-bartoszek @oli-obk @bors @flip1995 @phansch