Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent symbocalypse #4110

Merged
merged 4 commits into from
May 18, 2019
Merged

Prevent symbocalypse #4110

merged 4 commits into from
May 18, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 17, 2019

r? @Manishearth

This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us

changelog: none

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2019

📌 Commit f7f85a0 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented May 17, 2019

⌛ Testing commit f7f85a0 with merge 8056c40...

bors added a commit that referenced this pull request May 17, 2019
Prevent symbocalypse

r? @Manishearth

This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us

changelog: none
@bors
Copy link
Collaborator

bors commented May 17, 2019

💔 Test failed - status-appveyor

@oli-obk
Copy link
Contributor Author

oli-obk commented May 17, 2019

@bors r- gonna turn off those serde tests for now

@oli-obk
Copy link
Contributor Author

oli-obk commented May 17, 2019

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented May 17, 2019

📌 Commit 462df72 has been approved by Manishearth

bors added a commit that referenced this pull request May 17, 2019
Prevent symbocalypse

r? @Manishearth

This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us

changelog: none
@bors
Copy link
Collaborator

bors commented May 17, 2019

⌛ Testing commit 462df72 with merge d649981...

@bors
Copy link
Collaborator

bors commented May 17, 2019

💔 Test failed - status-appveyor

@oli-obk
Copy link
Contributor Author

oli-obk commented May 17, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2019

📌 Commit f49ef0e has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented May 17, 2019

⌛ Testing commit f49ef0e with merge 60a609a...

bors added a commit that referenced this pull request May 17, 2019
Prevent symbocalypse

r? @Manishearth

This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us

changelog: none
@bors
Copy link
Collaborator

bors commented May 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 60a609a to master...

@bors bors merged commit f49ef0e into master May 18, 2019
@oli-obk oli-obk deleted the symbolic_wasteland branch May 18, 2019 08:02
bors added a commit to rust-lang/rust that referenced this pull request May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants