Lint explicit Clone implementations on Copy type #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ A collection of lints to catch common mistakes and improve your Rust code. | |||
| [Jump to usage instructions](#usage) | |||
|
|
|||
| ##Lints | |||
| There are 97 lints included in this crate: | |||
| There are 98 lints included in this crate: | |||
|
LGTM. |
llogiq
added a commit
that referenced
this pull request
Jan 24, 2016
Lint explicit Clone implementations on Copy type
|
Note that if the type is always Copy, an explicit clone impl is much more efficient, something like this one: impl<T> Clone for Foo<T> {
fn clone(&self) -> Self { *self }
}This is faster to compile, and optimizes better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rust-lang/rust#31086.