Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented constant expression evaluation for repeat_once #7482

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

xFrednet
Copy link
Member

Documents the fact that the repeat_once lint evaluates constant expressions


closes: #7306

changelog: none
(I don't think it's worth a change log entry, as nothing has really changed)

r? @giraffate as you've implemented the lint and were part of the discussion in the issue 🙃

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2021
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Collaborator

bors commented Jul 24, 2021

📌 Commit 544c462 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Jul 24, 2021

⌛ Testing commit 544c462 with merge ea69a9d...

@bors
Copy link
Collaborator

bors commented Jul 24, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing ea69a9d to master...

@bors bors merged commit ea69a9d into rust-lang:master Jul 24, 2021
@xFrednet xFrednet deleted the 7306-document-repeat-once-fp branch July 28, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repeat_once triggers when the parameter is a constant
4 participants